Update tx service delegate methods - Githubissues

safe-global / safe-cli

Command line utility for Safe

MIT License

208 stars 68 forks source link

Update tx service delegate methods #427

Closed falvaradorodriguez closed 2 months ago

falvaradorodriguez commented 2 months ago

Closes https://github.com/safe-global/safe-cli/issues/425

falvaradorodriguez commented 2 months ago

A new release of safe-eth-py is needed as the method that calculates the delegate signature in the current version is incorrect. Anyway, the task work in safe-cli would be ready.

coveralls commented 2 months ago

coverage: 87.308% (+0.03%) from 87.279% when pulling 82ef773b8620a1cbbb685b35fa381e1ff01b8819 on update_tx_service_delegate_methods into a9427b222f74866642a6a37ee1a2f5df19826bd2 on main.

coveralls commented 2 months ago

coverage: 87.497% (+0.03%) from 87.47% when pulling ca3750a77842798c63476748f3dfb70a15ae27fb on update_tx_service_delegate_methods into ddd66d66093ddebbe1a9301319e1b8121d21a81d on main.

coveralls commented 2 months ago

coverage: 88.593% (+0.02%) from 88.571% when pulling 95e874c40f32bda088045438123bc9b225c0b2a8 on update_tx_service_delegate_methods into f343bb8c4020de06108c453e290327166d29afe2 on main.

coveralls commented 2 months ago

coverage: 88.602% (+0.03%) from 88.571% when pulling 465f46eb4fd4700f296c7285c563fac2bfbd625c on update_tx_service_delegate_methods into f343bb8c4020de06108c453e290327166d29afe2 on main.

falvaradorodriguez commented 2 months ago

Added a blocked label to wait for a new version of safe-eth-py with the signature EIP712 fixed

coveralls commented 2 months ago

coverage: 88.602% (+0.02%) from 88.58% when pulling ab20b376ba7c6343dd5efcbe44ecda9f3b1e1cd9 on update_tx_service_delegate_methods into d59dc929a03de12bb50693ffd7a461c040dec79d on main.

coveralls commented 2 months ago

coverage: 88.602% (+0.02%) from 88.58% when pulling 58f2ecec4180af378c58e02f1b92ab15b7b67dd6 on update_tx_service_delegate_methods into d59dc929a03de12bb50693ffd7a461c040dec79d on main.