safe-global / safe-cli

Command line utility for Safe
MIT License
208 stars 68 forks source link

Remove exception with invalid contract method name in tx-builder #429

Closed falvaradorodriguez closed 2 months ago

falvaradorodriguez commented 2 months ago

Related with https://github.com/safe-global/safe-cli/issues/36 Problem detected in QA validation.

When the method we are trying to encode is not valid, we are throwing an exception. This is an error, following the front-end tx-builder steps here should return a None.

coveralls commented 2 months ago

Coverage Status

coverage: 88.58% (+0.009%) from 88.571% when pulling 45609cd2209cb34d51ebbfa68e79f7b5d478178d on fix_tx_builder_decoder into f343bb8c4020de06108c453e290327166d29afe2 on main.