safe-global / safe-client-gateway

Serves as a bridge for the Safe{Wallet} clients (Android, iOS, Web)
https://docs.safe.global
MIT License
27 stars 64 forks source link

Don't allow empty/hex strings to be validated as numeric strings #2109

Closed iamacook closed 5 days ago

iamacook commented 1 week ago

Summary

Our NumericStringSchema validates empty strings (0) and hexadecimal strings, but it shouldn't. This prevents empty/hex strings from passing validation.

Note: it also corrects mock data that was assumed hex, when it should be numeric.

Changes