[Web3Auth Safe Signer] QA the new integration

yagopv commented 10 months ago

Context

Following the implementation of the new Web3AuthPack #565 we should QA the solution

Proposed solution

The expected outcome is generating a notion page report that will be shared with Web3Auth in order to fix the issues found in the new integration

We need to deploy a site with the new integration working in order to QA it (demo app?)

Additional context

Web3Auth Safe Signer epic

yagopv commented 10 months ago

Generated QA doc

yagopv commented 9 months ago

@JagoFigueroa in order to test this ticket we have 3 example dApps deployed and the Safe{Wallet} web

5afe demo UI: https://account-abstraction-demo-ui.netlify.app (Goerli, Mumbai, Gnosis Chain, Ethereum, Polygon, Sepolia) Safe Core SDK Example app: https://auth-kit-example.netlify.app/?chainId=0x64 (Chain support) Web3Auth Example App: https://w3a-safe-demo.vercel.app (Gnosis Chain) Safe{Wallet}: https://app.safe.global (Goerli and Gnosis Chain)

We need to ensure the following assertions are true between the above web sites:

[x] Signers generated in any dApp should be the same (same signer address)
[x] Signers generated in any dApp in different chains should be the same (same signer address, different Safe accounts per chain)
[ ] Safe management between dApps and Safe{Wallet} should work seamlessly including factors management (Entering passwords to activate browsers, ...etc.)
[x] Should allow to login with existing Google accounts and to create new ones
[x] Should ask to configure 2FA in every third login with an account that never configured it previously

JagoFigueroa commented 9 months ago

I am having a couple of issues. Maybe we can do some further debugging on them together and open the necessary tickets if needed as they are a bit tricky.

I have an account that was created on an older version of the auth kit that works as expected on all apps following the checks posted above but I am having trouble when it comes to change the password on the safe web app, no matter what I do I am getting an invalid password error and I shouldn't as I am able to use my current password for logins and revealing my private key on web too. I do not know if it may be related to this deployment but I think it is work a 👀 as this can be quite problematic for users. Edit: the guys from web have confirmed that no issues on their end so it should reduce the scope a bit.
Using firefox, I have created a new account and set a password for it but instead of getting the popup for password verification the one I get is to set a 2FA every time. I understand this shouldn't be the case as I have already set a password via that pop up the first time. Attaching a video:

https://github.com/safe-global/safe-core-sdk/assets/92332710/3e540502-911c-45f4-9612-85230271a72e

Edit: attaching a second video of me following the flow trying to set a password for an account that already has one for more details. This look to not be possible at least.

https://github.com/safe-global/safe-core-sdk/assets/92332710/99b35e06-6dcd-4c5a-8d0b-7a5410d00d6c

JagoFigueroa commented 9 months ago

The reported above has been reported to the team, not much we can do on our side so QA approved from my end 😄

JagoFigueroa commented 9 months ago

Update on issue número 2, it was caused by not saving the current browser as a device. Web3auth team confirmed that this was a required step so they removed the option to skip that step.

All good now 😄

safe-global / safe-core-sdk