`SafeFactory.deploySafe` should have the option to add modules to a safe on deploy

[froggiedev]

Context / issue

To improve the user experience of deploying new safes within applications for AA.

In case your feature request related to a problem, please add clear and concise description of what the issue is.

Users have to make too many transactions to prepare a Smart Account for usage as a bundler.

Please add a clear and concise description of what you want to happen.

SafeFactory.deploySafe should have an additional modules: string[] option that is passed to the setup of the safe and automatically enabled after deployment, without requiring a second transaction.

Please add a clear and concise description of any alternative solutions or features you have considered.

Keep the user-experience poor.

[valeryz]

You can do this by passing suitable to and data arguments to deploySafe, and adding the follwoing to your module:

import "@gnosis.pm/safe-contracts/contracts/GnosisSafe.sol";

contract MyAwesomeModule {
    ...
    // Can only be called as delegatecall from a GnosisSafe during setup.
    function enableModule(address module) external {
        address payable thisAddr = payable(address(this));
        GnosisSafe(thisAddr).enableModule(module);
    }
   ...
}

then you first create your module, then deploy:

       const iface = new ethers.utils.Interface(["function enableModule(address module)"]);
       const safeAccountConfig: SafeAccountConfig =  {
           owners: owners,
           threshold: <threhold>,
           to: myAwesomeModule.address,
           data: iface.encodeFunctionData("enableModule", [myAwesomeModule.address])
       };

       safe = await safeFactory.deploySafe({ safeAccountConfig });

it will delegatecall into your module while allowing you do to anything as initial set up of the Safe.

[froggiedev]

You can do this by passing suitable to and data arguments to deploySafe, and adding the follwoing to your module:

import "@gnosis.pm/safe-contracts/contracts/GnosisSafe.sol";

contract MyAwesomeModule {
    ...
    // Can only be called as delegatecall from a GnosisSafe during setup.
    function enableModule(address module) external {
        address payable thisAddr = payable(address(this));
        GnosisSafe(thisAddr).enableModule(module);
    }
   ...
}

then you first create your module, then deploy:

       const iface = new ethers.utils.Interface(["function enableModule(address module)"]);
       const safeAccountConfig: SafeAccountConfig =  {
           owners: owners,
           threshold: <threhold>,
           to: myAwesomeModule.address,
           data: iface.encodeFunctionData("enableModule", [myAwesomeModule.address])
       };

       safe = await safeFactory.deploySafe({ safeAccountConfig });

it will delegatecall into your module while allowing you do to anything as initial set up of the Safe.

Perfect, thanks.

[ashwinYardi]

hey guys, I have a doubt related to the method being used here for enabling a module.

As per the discussion:

• This works. Function A is called successfully.

• But this doesnt, when I wrap my module behind a proxy. Function is not called at all in this case.

Am I missing anything?

@froggiedev @valeryz