The api-kit test was failing because it was relying on the length of the results array instead of using the count property value. From 100 items, the call is automatically paginated, so count should always be used for these types of comparisons
A cache has been added in the Safe4337Pack instantiation, as the protocol-kit initialization takes time, and most of the instances can be reused
What it solves
Resolves https://github.com/safe-global/safe-core-sdk/issues/827
How this PR resolves it
The
api-kit
test was failing because it was relying on the length of the results
array instead of using the count
property value. From 100 items, the call is automatically paginated, so count
should always be used for these types of comparisonsA cache has been added in the
Safe4337Pack
instantiation, as theprotocol-kit
initialization takes time, and most of the instances can be reusedThe timeout has been increased