feat(api-kit): Support for SafeOperation confirmations endpoints

tmjssz commented 1 week ago

What it solves

Resolves #856

How this PR fixes it

Extend the api-kit by two functions using the following endpoints of the transaction-service.

getSafeOperationConfirmations

Returns the list of confirmations for a given a SafeOperation.

GET /v1/safe-operations/{safe_operation_hash}/confirmations/

confirmSafeOperation

Adds a confirmation for a SafeOperation.

POST /v1/safe-operations/{safe_operation_hash}/confirmations/

coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 9592708241

Details

9 of 18 (50.0%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.5%) to 77.39%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
packages/relay-kit/src/packs/safe-4337/SafeOperation.ts	1	2	50.0%
packages/relay-kit/src/packs/safe-4337/Safe4337Pack.ts	0	3	0.0%
packages/api-kit/src/SafeApiKit.ts	8	13	61.54%
<!--	Total:	9	18	50.0%	-->

Totals
Change from base Build 9485617547:	-0.5%
Covered Lines:	792
Relevant Lines:	949

Pull Request Test Coverage Report for Build 9592817524

Details

9 of 18 (50.0%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.5%) to 77.39%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
packages/relay-kit/src/packs/safe-4337/SafeOperation.ts	1	2	50.0%
packages/relay-kit/src/packs/safe-4337/Safe4337Pack.ts	0	3	0.0%
packages/api-kit/src/SafeApiKit.ts	8	13	61.54%
<!--	Total:	9	18	50.0%	-->

Totals
Change from base Build 9485617547:	-0.5%
Covered Lines:	792
Relevant Lines:	949

Pull Request Test Coverage Report for Build 9599977083

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

9 of 18 (50.0%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.5%) to 77.39%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
packages/relay-kit/src/packs/safe-4337/SafeOperation.ts	1	2	50.0%
packages/relay-kit/src/packs/safe-4337/Safe4337Pack.ts	0	3	0.0%
packages/api-kit/src/SafeApiKit.ts	8	13	61.54%
<!--	Total:	9	18	50.0%	-->

Totals
Change from base Build 9485617547:	-0.5%
Covered Lines:	792
Relevant Lines:	949

💛 - Coveralls

tmjssz commented 1 week ago

Some tests related to SafeDelegates started to fail, but it seems unrelated to my changes because I'm getting the same errors on the development branch

dasanra commented 1 week ago

Don't worry about the tests, they are not related with this PR. Already checked with the API team.

coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 9614186193

Details

9 of 18 (50.0%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.5%) to 77.607%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
packages/relay-kit/src/packs/safe-4337/SafeOperation.ts	1	2	50.0%
packages/relay-kit/src/packs/safe-4337/Safe4337Pack.ts	0	3	0.0%
packages/api-kit/src/SafeApiKit.ts	8	13	61.54%
<!--	Total:	9	18	50.0%	-->

Totals
Change from base Build 9614168250:	-0.5%
Covered Lines:	787
Relevant Lines:	944

💛 - Coveralls

coveralls commented 4 days ago

Pull Request Test Coverage Report for Build 9646217403

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

12 of 19 (63.16%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.3%) to 77.778%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
packages/relay-kit/src/packs/safe-4337/Safe4337Pack.ts	2	3	66.67%
packages/relay-kit/src/packs/safe-4337/SafeOperation.ts	2	3	66.67%
packages/api-kit/src/SafeApiKit.ts	8	13	61.54%
<!--	Total:	12	19	63.16%	-->

Totals
Change from base Build 9614168250:	-0.3%
Covered Lines:	790
Relevant Lines:	945

💛 - Coveralls

coveralls commented 3 days ago

Pull Request Test Coverage Report for Build 9666618943

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

12 of 19 (63.16%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.7%) to 77.417%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
packages/relay-kit/src/packs/safe-4337/Safe4337Pack.ts	2	3	66.67%
packages/relay-kit/src/packs/safe-4337/SafeOperation.ts	2	3	66.67%
packages/api-kit/src/SafeApiKit.ts	8	13	61.54%
<!--	Total:	12	19	63.16%	-->

Totals
Change from base Build 9614168250:	-0.7%
Covered Lines:	774
Relevant Lines:	929

💛 - Coveralls

coveralls commented 2 days ago

Pull Request Test Coverage Report for Build 9676087509

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

18 of 31 (58.06%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.7%) to 77.417%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
packages/relay-kit/src/packs/safe-4337/Safe4337Pack.ts	2	3	66.67%
packages/relay-kit/src/packs/safe-4337/SafeOperation.ts	2	3	66.67%
packages/api-kit/src/SafeApiKit.ts	14	25	56.0%
<!--	Total:	18	31	58.06%	-->

Totals
Change from base Build 9614168250:	-0.7%
Covered Lines:	774
Relevant Lines:	929

safe-global / safe-core-sdk