feat(safe-kit): Multisig - Githubissues

safe-global / safe-core-sdk

The Safe{Core} SDK allows builders to add account abstraction functionality into their apps.

https://docs.safe.global/sdk/overview

MIT License

242 stars 177 forks source link

feat(safe-kit): Multisig #885

Open yagopv opened 4 days ago

yagopv commented 4 days ago

What it solves

Resolves https://github.com/safe-global/safe-core-sdk/issues/868

How this PR fixes it

Add getPendingTransaction() method to get the list of transactions that should be confirmed
Add confirm(safeTxHash) method to confirm pending transactions
send(options) now covers the following flows: 1) Safe deployment and transaction execution (threshold 1 new Safe) 2) Transaction execution (threshold 1 existing Safe) 3) Safe deployment and transaction proposal (threshold > 1 new Safe) 4) transaction proposal (threshold > 1 existing Safe)
confirm(safeTxHash) now covers: 1) transaction execution (threshold 1 existing Safe) 2) transaction proposal (threshold > 1 existing Safe)

coveralls commented 3 days ago

Pull Request Test Coverage Report for Build 9659411856

Details

2 of 9 (22.22%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.4%) to 77.298%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
packages/safe-kit/src/SafeClient.ts	2	9	22.22%
<!--	Total:	2	9	22.22%	-->

Totals
Change from base Build 9659157719:	-0.4%
Covered Lines:	763
Relevant Lines:	920

💛 - Coveralls

coveralls commented 3 days ago

Pull Request Test Coverage Report for Build 9659434141

Details

2 of 9 (22.22%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.4%) to 77.298%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
packages/safe-kit/src/SafeClient.ts	2	9	22.22%
<!--	Total:	2	9	22.22%	-->

Totals
Change from base Build 9659157719:	-0.4%
Covered Lines:	763
Relevant Lines:	920

💛 - Coveralls

coveralls commented 2 days ago

Pull Request Test Coverage Report for Build 9678242555

Details

2 of 33 (6.06%) changed or added relevant lines in 1 file are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-2.9%) to 74.826%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
packages/safe-kit/src/SafeClient.ts	2	33	6.06%
<!--	Total:	2	33	6.06%	-->

Files with Coverage Reduction	New Missed Lines	%
packages/safe-kit/src/SafeClient.ts	4	8.0%
<!--	Total:	4		-->

Totals
Change from base Build 9659157719:	-2.9%
Covered Lines:	754
Relevant Lines:	939

💛 - Coveralls

coveralls commented 2 days ago

Pull Request Test Coverage Report for Build 9682580932

Details

2 of 36 (5.56%) changed or added relevant lines in 1 file are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-3.1%) to 74.653%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
packages/safe-kit/src/SafeClient.ts	2	36	5.56%
<!--	Total:	2	36	5.56%	-->

Files with Coverage Reduction	New Missed Lines	%
packages/safe-kit/src/SafeClient.ts	4	7.55%
<!--	Total:	4		-->

Totals
Change from base Build 9659157719:	-3.1%
Covered Lines:	754
Relevant Lines:	942

💛 - Coveralls

coveralls commented 1 day ago

Pull Request Test Coverage Report for Build 9698386852

Details

10 of 50 (20.0%) changed or added relevant lines in 2 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-3.0%) to 74.676%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
packages/safe-kit/src/SafeClient.ts	3	43	6.98%
<!--	Total:	10	50	20.0%	-->

Files with Coverage Reduction	New Missed Lines	%
packages/safe-kit/src/SafeClient.ts	1	8.77%
<!--	Total:	1		-->

Totals
Change from base Build 9659157719:	-3.0%
Covered Lines:	762
Relevant Lines:	953

💛 - Coveralls