search

safe-global / safe-homepage

Safe homepage
https://safe.global
MIT License
5 stars 14 forks source link

feat: 🎸 Add Cexes Comparison Section #429

Closed Malayvasa closed 3 months ago

Malayvasa commented 3 months ago

Related to #382

DiogoSoaress commented 3 months ago

Why aren't you fetching the values dynamically?

Malayvasa commented 3 months ago

@DiogoSoaress Can you please advise on how to do the data fetching?

As per my understanding, when we had discussed on how we divide the work I was to implement the sections with static data and not look at the data fetching logic.

DiogoSoaress commented 3 months ago

when we had discussed on how we divide the work I was to implement the sections with static data and not look at the data fetching logic

That was indeed the agreement when we were developing V1 so you could concentrate on the animations. Data fetching is already implemented (you even used it for the WorldGDP implementation https://github.com/safe-global/safe-homepage/pull/418/files#diff-b538657fbd34189db0dce0f876fd3eef4d53835bcd82a64539c37608e62adfa8)

What I am asking is for you to pull the real values from that useSafeDataRoomStats hook.

Malayvasa commented 3 months ago

[RESOLVED via Slack] @DiogoSoaress I have noticed that I ended up duplicating the data fetching for the TVL value of Safe as that was being used in World GDP section as well. Can you suggest as to which one should I keep and which one should I remove?

Now that we have the TVL values of other Cexes, I feel the tvlSafe naming is better than just totalValueLocked.