search

safe-global / safe-infrastructure

One `docker-compose.yml` file to rule them all
MIT License
56 stars 92 forks source link

fix: compose issues #119

Closed bilbeyt closed 10 months ago

bilbeyt commented 10 months ago

I had problems running docker-compose in my MAC and i solved problems with these changes.

  1. ui service change: for some reason, safe-wallet-web image has no contract types generated. (afterinstall is failing). I have adapted the command the fix the issue. (https://github.com/safe-global/safe-wallet-web/issues/2656)
  2. As cgw and ui are using different ports and cgw has no enabled cors, i couldnt use compose without setting cors headers for the cgw. (in a different setup for production this might not be a problem so i dont create issue for this nginx change in cgw repo)
github-actions[bot] commented 10 months ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

bilbeyt commented 10 months ago

I have read the CLA Document and I hereby sign the CLA

Uxio0 commented 10 months ago

Hi @bilbeyt and thank you very much for your PR. We analyzed your solution but we decided to go with #121, which in our opinion makes configuration easier making UI and services run from the same nginx instance, so there's no CORS issues.

Again, thank you very much for your time.