Issue to deploy safe infrastructure on a new chain

gnarco commented 11 months ago

We want to follow the procedure described it here : https://github.com/safe-global/safe-infrastructure

So we started adding our token to safe-deployment repo and request a bump in the NPM package. Done.

But, other libraries / tools still refer to old versions that does not include the newest safe-deployment package.

So, it seems that the whole stack needs to be bumped

is it right ? or do we miss something ?

Thanks !

mmv08 commented 11 months ago

Npm allows you to rewrite package resolutions. You can also patch the dependency to include your addresses. There are many solutions. If you wish to request a deployment/upgrade, please create an issue/PR in the corresponding repo.

JABirchall commented 10 months ago

How do I override the deployments package for the UI?

The only thing stopping me from deploying safe-wallets for my chain is UI erroring Uncaught (in promise) Error: Invalid CompatibilityFallbackHandler contract address

I had an issue open to increase the deployments version on the web repo and they wont because it needs to be tested. Its currently 5 months behind and my chain was added 3 months ago.

mmv08 commented 10 months ago

How do I override the deployments package for the UI?

The only thing stopping me from deploying safe-wallets for my chain is UI erroring Uncaught (in promise) Error: Invalid CompatibilityFallbackHandler contract address

I had an issue open to increase the deployments version on the web repo and they wont because it needs to be tested. Its currently 5 months behind and my chain was added 3 months ago.

Hmm, I'm not sure if it's possible with docker compose. Perhaps you could run the UI separately and update the dependency in the package.json there. CC @katspaugh

katspaugh commented 10 months ago

In the frontend repo, the following has to be done to support a new chain:

The safe-deployments repo must be updated with the new chain and contract addresses, and a new version thereof must be released.
The safe-core-sdk should be updated to use the new safe-deployments version and a new version of the SDK must be released.
In the frontend repo, both safe-deployments and safe-core-sdk versions must be set to those new versions.
The new chain must be added and enabled in the safe-config-service via the Django admin.

JABirchall commented 10 months ago

In the frontend repo, the following has to be done to support a new chain:

* The [safe-deployments](https://github.com/safe-global/safe-deployments) repo must be updated with the new chain and contract addresses, and a new version thereof must be released.

* The [safe-core-sdk](https://github.com/safe-global/safe-core-sdk/tree/v3.3.3) should be updated to use the new **safe-deployments** version and a new version of the SDK must be released.

* In the [frontend repo](https://github.com/safe-global/safe-wallet-web), both **safe-deployments** and **safe-core-sdk** versions must be set to those new versions.

* The new chain must be added and enabled in the [safe-config-service](https://github.com/safe-global/safe-config-service) via the Django admin.

the only step in that, is the webui isnt updated and is 4 versions behind the latest and 3 versions behind the SDK. My chain was added in 1.28.0, all other repos are upto that version except the web ui which is still on 1.25.0

katspaugh commented 10 months ago

Great, then please feel free to update the packages in the UI, I'll accept the PR. 👍

JABirchall commented 9 months ago

Great, then please feel free to update the packages in the UI, I'll accept the PR. 👍

Ok now that thats all merged and a release made, i updated the docker version and its now saying the proxy contract address is invalid? Uncaught (in promise) Error: Invalid SafeProxyFactory contract address

But it is there: https://explorer.hypra.network/address/0xa6B71E26C5e0845f74c812102Ca7114b6a896AB2

Im not sure whats wrong here.

hapetherw commented 8 months ago

@katspaugh Could you please upgrade both Safe-Core-SDK and Safe-Wallet-Web versions based on the new safe-deployment release version(v1.33.0)? any approximate timeframe for this? thanks.

moisses89 commented 6 months ago

The ui version was updated in the .env file, is this still happening?.

moisses89 commented 6 months ago

Last version should fix the issue, closing due inactivity.

katspaugh commented 6 months ago

Sorry I should've mentioned here: the packages were updated. So all good.

safe-global / safe-infrastructure

Issue to deploy safe infrastructure on a new chain #124