safe-global / safe-ios

Safe Multisig iOS app.
GNU General Public License v3.0
114 stars 37 forks source link

[iOS] [Web3Auth] UI for displaying social owner keys #3226

Closed TanyaEfremova closed 10 months ago

TanyaEfremova commented 1 year ago

Bug description Logo's of Google and Apple ID are too big and in the Dark Mode it's hard to see them well.

Steps To Reproduce

  1. Create a Safe account with Google or Apple ID on Gnosis Chain
  2. Go to Safe settings and see the created owner OR go to owner keys in the App settings and find a social login owner type

Expected Result Icons should not be bigger than 12px (both Google and Apple ID)

Screenshot 2023-07-28 at 14 06 38

Screenshots

Screenshot 2023-07-20 at 14 42 49

Device & App version

Environment TestFlight

Additional info (Optional)

liliya-soroka commented 1 year ago

Reopened: app version 3.22.0(1892) Google and Apple icons are fixed, but all other icons are broken after the fix. After the fix: Image

Before the fix

Image

TanyaEfremova commented 1 year ago

The Apple icon is too small for some reason. Can we ensure, that this one is used? bdg-key-type-web3auth-apple.pdf

Screenshot 2023-08-03 at 10 11 55
DmitryBespalov commented 1 year ago

thanks, that differs from the one I got before

DmitryBespalov commented 1 year ago

@TanyaEfremova the icon you shared needs to be 32x32, but it's 24x24

TanyaEfremova commented 1 year ago

bdg-key-type-web3auth-apple.pdf Here is the 32x32 version @DmitryBespalov

liliya-soroka commented 1 year ago

Verified app version 3.23.0(1914)