[iOS] update wallet connect to v2 for key connection

safe-global / safe-ios

Safe Multisig iOS app.

GNU General Public License v3.0

115 stars 37 forks source link

[iOS] update wallet connect to v2 for key connection #3365

Closed DmitryBespalov closed 10 months ago

DmitryBespalov commented 1 year ago

WalletConnect v1 was switched off on the services side, so we need to use WalletConnect v2 for connecting keys.

liliya-soroka commented 11 months ago

Checked apps

[x] Rainbow - can not connect
[ ] MM mobile app signing doesn't work - RPC error
[ ] Trust Wallet can not enable push notification
[ ] Argent No connection pop up in the Argent wallet
[ ] Pillar Connection is available only on Ethereum

DmitryBespalov commented 11 months ago

Rainbow

The issue is that Rainbow doesn't support Görli now. To enable it, you should go to Rainbow's Settings - Developer Settings - Enable Testnets. Then there's a toggle to switch network to Görli. However, when I tried it, it didn't switch to other network.

Even without the testnet, if the Safe is on Ethereum, then Rainbow will pick up the Ethereum network just OK and you can connect to it.

List of networks that Rainbow says it can connect to:

Chain ID 1, Ethereum
Chain ID 42161, Arbitrum One
Chain ID 8453, Base
Chain ID 10, Optimism Mainnet
Chain ID 137, Polygon Mainnet
Chain ID 7777777, Zora
Chain ID 56, BNB Smart Chain Mainnet

Unfortunately, Goerli and Gnosis Chain are not in that list

DmitryBespalov commented 11 months ago

Argent

Select the "Ethereum" vault and the connection request appears

DmitryBespalov commented 11 months ago

Pillar For me, it even doesn't connect to Ethereum wallet

DmitryBespalov commented 11 months ago

Metamask I saw that the issue is supposed to be fixed already but I still get the invalid signature. I will create a workaround for that.

liliya-soroka commented 11 months ago

Seems, that incorrect network id is sent by the safe mobile app for connection when it's not Ethereum:

liliya-soroka commented 11 months ago

Result of testing:

MM -safe mobile app - connection works on diff networks
other checked wallets(Rainbow/Trust wallet/Pillar/imToken): connection works only on Ethereum. For other networks eipXXX is displayed instead of network during connection

liliya-soroka commented 11 months ago

Verified: if the wallet supports the network and the same networks is selected in the safe app and connected wallet, connection works without an issue In case when different networks are used in safe and connected wallet the same error is displayed as for the safe mobile app as for the safe web app