search

safe-global / safe-modules

A collection of modules that can be used with the Safe contract
GNU Lesser General Public License v3.0
137 stars 73 forks source link

Ambigious behaviour with WebAuthn shim #369

Closed remedcu closed 1 week ago

remedcu commented 3 months ago

Description

The test "Should authorise and verify an existing credential" in the WebAuthn Shim section fails unexpectedly (Source)

Steps to reproduce

This fails rarely, as the next run of the job returns true.

Additional context

The problem was found during changes created in PR #356 (though no change in the concerned file was made).

nlordell commented 3 months ago

Uploading the log archive in case GitHub decides to delete the run.

logs_22525924257.zip

remedcu commented 2 weeks ago

Another failure, this time with the e2e CI script.

Log Link: https://github.com/safe-global/safe-modules/actions/runs/9990468990/job/27611219692 Log Archive: logs_26151611198.zip

nlordell commented 2 weeks ago

I think that is an unrelated issue @remedcu, in fact the WebAuthn shim does not appear to be used in the failing test - it is just taking a little more gas than expected.

nlordell commented 2 weeks ago

I think I found the issue, and it lies in the SimpleWebAuthn library that we use: https://github.com/MasterKale/SimpleWebAuthn/pull/594

mmv08 commented 1 week ago

what a legend