Promote Shared Singleton Signer Implementation

nlordell commented 6 months ago

This PR promotes the shared singleton signer implementation to the 4337 directory instead of being a "test" contract. This involves:

Adding it to the deployments
Moving and renaming the contract to remove the Test prefix

I also took this opportunity to rename it to a "shared" signer instead of "singleton" signer, so that it does not get confused with the other singleton contract (the SafeWebAuthnSignerSingleton) that already exists in this repository.

Additionally, I moved some of the test files around in order to clearly differentiate between E2E tests and unit tests in the test/4337 directory.

Unit tests for 100% coverage of the SafeWebAuthnSharedSigner will be added in a follow up PR.

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 9062104545

Details

1 of 15 (6.67%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-8.4%) to 77.833%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
modules/passkey/contracts/4337/SafeWebAuthnSharedSigner.sol	1	15	6.67%
<!--	Total:	1	15	6.67%	-->

Totals
Change from base Build 9031345321:	-8.4%
Covered Lines:	122
Relevant Lines:	147

💛 - Coveralls

nlordell commented 5 months ago

I suspect there was a small change in comments or something related to the rebase. I created a GH issue to track this, so we can redeploy the contracts once the audit is complete (as the addresses may change yet again when we incorporate audit comments):

https://github.com/safe-global/safe-modules/issues/418

safe-global / safe-modules