safe-global / safe-modules

A collection of modules that can be used with the Safe contract
GNU Lesser General Public License v3.0
140 stars 73 forks source link

Shared Signer Mapping #429

Closed nlordell closed 3 months ago

nlordell commented 3 months ago

This PR changes the behaviour of the shared signer to store its configuration as if it were behind a mapping where the key is the shared signer address. This allows multiple shared signer instances to be configured for a single account (in case you ever need to deploy a 2/2 Safe owned by passkeys with 4337).

I created an "accessor" contract to prove that the storage location is indeed the equivalent to a mapping(address self => Signer).

nlordell commented 3 months ago

Do not merge until the Certora audit is complete.

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 9380824990

Details


Totals Coverage Status
Change from base Build 9380559112: 0.0%
Covered Lines: 149
Relevant Lines: 149

💛 - Coveralls