safe-global / safe-modules

A collection of modules that can be used with the Safe contract
GNU Lesser General Public License v3.0
140 stars 73 forks source link

Add Test With Precompile #430

Closed nlordell closed 3 months ago

nlordell commented 3 months ago

Fixes #317

This PR adds a new docker-compose file for running a local Geth node (based on the Optimism Geth node) with RIP-7212 precompile support in order verify that the Safe WebAuthn verifier actually works with the [ER]IP-7212 precompile.

In particular, we just use the @bench tests which are already run in CI and would give us a rough idea on how much gas a Passkey signature verification will take with the precompile (spoiler - its just 15k gas, which is reasonable).

I did not create a dedicated E2E test, as I felt it didn't have much value.

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 9380395988

Details


Totals Coverage Status
Change from base Build 9366412389: 0.0%
Covered Lines: 39
Relevant Lines: 39

💛 - Coveralls
coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 9380395987

Details


Totals Coverage Status
Change from base Build 9366412389: 0.0%
Covered Lines: 147
Relevant Lines: 147

💛 - Coveralls