search

safe-global / safe-modules

A collection of modules that can be used with the Safe contract
GNU Lesser General Public License v3.0
140 stars 73 forks source link

Fix `runOp` Script #435

Closed nlordell closed 3 months ago

nlordell commented 3 months ago

I was running the 4337 runOp.ts script this morning and noticed it was subtly broken. This PR fixes it.

I also refactored the scripts a bit - specifically we no longer --fix on lint:ts. This was because it would cause CI to silently pass in cases where the linter could autofix the code (when we want it to fail instead).

mmv08 commented 3 months ago

I was running the 4337 runOp.ts script this morning and noticed it was subtly broken. This PR fixes it.

I think I wrote the runOp.ts script in 2022 to test sending a user operation against a production bundler, since now we have e2e tests with a local bundler, is there any use to this script at all?

nlordell commented 3 months ago

I use it to send a user operation to an actual chain (Sepolia in my case). It is still convenient IMO.