safe-global / safe-modules

A collection of modules that can be used with the Safe contract
GNU Lesser General Public License v3.0
140 stars 73 forks source link

Check for Double Initialization #436

Closed nlordell closed 2 months ago

nlordell commented 2 months ago

The test/example Safe signer launchpad pattern in the ERC-4337 module directory did not contain an important security check preventing double initialization which could lead to an account being taken over.

In order to better document the security requirements for such a contract, we added the double initialization check to the pre-validation setup.

Huge kudos to Ackee Blockchain for bringing this to our attention :muscle:.

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 9478640395

Details


Totals Coverage Status
Change from base Build 9444900044: 0.0%
Covered Lines: 39
Relevant Lines: 39

💛 - Coveralls