Feature: 4337 module `v0.3.0-1`

safe-global / safe-modules

A collection of modules that can be used with the Safe contract

GNU Lesser General Public License v3.0

140 stars 73 forks source link

Feature: 4337 module `v0.3.0-1` #445

Closed mmv08 closed 2 months ago

mmv08 commented 2 months ago

This PR:

Implements https://github.com/safe-global/safe-modules/issues/426 by releasing the code we have now under a new tag
There were no contract changes, so the expected addresses are the same. I confirmed it by trying to deploy to a network where the contracts are already deployed:
```
> hardhat deploy-contracts --network "mainnet"
```

Nothing to compile No need to generate any newer typings. reusing "SafeModuleSetup" at 0x2dd68b007B46fBe91B9A7c3EDa5A7a1063cB5b47 reusing "Safe4337Module" at 0x75cf11467937ce3F2f357CE24ffc3DBF8fD5c226

akshay-ap commented 2 months ago

My understanding is that as the script has a bug fix, new version would be v0.3.1. Curious to know why there is v0.3.0-1 as new version instead? I couldn't find it as a convention in npm docs.

mmv08 commented 2 months ago

My understanding is that as the script has a bug fix, new version would be v0.3.1. Curious to know why there is v0.3.0-1 as new version instead? I couldn't find it as a convention in npm docs.

There is no bug in the script or the contracts per se. The bug is in the surrounding tooling. We had problems with NPM where it would generate a platform-specific lockfile and refuse to regenerate it on other platforms. This led the v0.3.0 to be only usable to deploy or verify contracts on the platform where the lockfile was generated, which happens to be Linux.

The version number suggestion came from Nick here