Closed mmv08 closed 2 months ago
Totals | |
---|---|
Change from base Build 9578863041: | 0.0% |
Covered Lines: | 39 |
Relevant Lines: | 39 |
Totals | |
---|---|
Change from base Build 9578863041: | 0.0% |
Covered Lines: | 39 |
Relevant Lines: | 39 |
Totals | |
---|---|
Change from base Build 9615652927: | -37.3% |
Covered Lines: | 29 |
Relevant Lines: | 39 |
Totals | |
---|---|
Change from base Build 9615652927: | 0.0% |
Covered Lines: | 39 |
Relevant Lines: | 39 |
Totals | |
---|---|
Change from base Build 9615652927: | 0.0% |
Covered Lines: | 39 |
Relevant Lines: | 39 |
Totals | |
---|---|
Change from base Build 9615652927: | 0.0% |
Covered Lines: | 39 |
Relevant Lines: | 39 |
Totals | |
---|---|
Change from base Build 9615652927: | 0.0% |
Covered Lines: | 39 |
Relevant Lines: | 39 |
Totals | |
---|---|
Change from base Build 9615652927: | 0.0% |
Covered Lines: | 39 |
Relevant Lines: | 39 |
Totals | |
---|---|
Change from base Build 9615652927: | 0.0% |
Covered Lines: | 39 |
Relevant Lines: | 39 |
Totals | |
---|---|
Change from base Build 9615652927: | 0.0% |
Covered Lines: | 39 |
Relevant Lines: | 39 |
Totals | |
---|---|
Change from base Build 9615652927: | 0.0% |
Covered Lines: | 39 |
Relevant Lines: | 39 |
Totals | |
---|---|
Change from base Build 9615652927: | 0.0% |
Covered Lines: | 39 |
Relevant Lines: | 39 |
Totals | |
---|---|
Change from base Build 9615652927: | 0.0% |
Covered Lines: | 39 |
Relevant Lines: | 39 |
This PR fixes https://github.com/safe-global/safe-modules/issues/425 by introducing a new
estimateUserOperationGas
function, which runs the simulation using AA's referenceEntryPointSimulations
contract to ensure we use correct estimations for our test user operations. Previously, we set them to arbitrarily high numbers to make the tests pass. I also improved a couple of tests where we setmaxFeePerGas
to 0 by actually obtaining the prefund value the account paid for the operation.The code was mostly borrowed from the account-abstraction reference bundler and is not suitable for use in a production environment.
It also includes the
logUserOperationGas
function, which fixes the core issue of displaying the actual gas used by the user operation.Example log:
I ran into some types issues on CI and just working on the issue. I'll add a GitHub comment to each one.