safe-global / safe-modules

A collection of modules that can be used with the Safe contract
GNU Lesser General Public License v3.0
140 stars 73 forks source link

Index Signer In Created Event #447

Closed nlordell closed 2 months ago

nlordell commented 2 months ago

As discussed internally with the team, we decided to index the signer field of the Created event from the passkey factory contract. This came as a follow up to event discussions from an issue raised from the Hats audit competition: https://github.com/hats-finance/Safe-0x2909fdefd24a1ced675cb1444918fa766d76bdac/issues/3

Note that this only slightly increases the deployment costs:

=== BEFORE ===
  Gas Benchmarking [@bench]
    SafeWebAuthnSignerProxy
      ⛽ deployment: 94366
      ✔ Benchmark signer deployment cost (476ms)

=== AFTER  ===
  Gas Benchmarking [@bench]
    SafeWebAuthnSignerProxy
      ⛽ deployment: 94476
      ✔ Benchmark signer deployment cost (476ms)

For reference, this is a 0.1% increase to the deployment gas costs.

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 9615480905

Details


Totals Coverage Status
Change from base Build 9578863041: 0.0%
Covered Lines: 90
Relevant Lines: 90

💛 - Coveralls