Closed nlordell closed 2 months ago
As discussed internally with the team, we decided to index the signer field of the Created event from the passkey factory contract. This came as a follow up to event discussions from an issue raised from the Hats audit competition: https://github.com/hats-finance/Safe-0x2909fdefd24a1ced675cb1444918fa766d76bdac/issues/3
signer
Created
Note that this only slightly increases the deployment costs:
=== BEFORE === Gas Benchmarking [@bench] SafeWebAuthnSignerProxy ⛽ deployment: 94366 ✔ Benchmark signer deployment cost (476ms) === AFTER === Gas Benchmarking [@bench] SafeWebAuthnSignerProxy ⛽ deployment: 94476 ✔ Benchmark signer deployment cost (476ms)
For reference, this is a 0.1% increase to the deployment gas costs.
As discussed internally with the team, we decided to index the
signer
field of theCreated
event from the passkey factory contract. This came as a follow up to event discussions from an issue raised from the Hats audit competition: https://github.com/hats-finance/Safe-0x2909fdefd24a1ced675cb1444918fa766d76bdac/issues/3Note that this only slightly increases the deployment costs:
For reference, this is a 0.1% increase to the deployment gas costs.