This PR marks regions of assembly that previously weren't as memory safe - this allows the IR optimizer to do a few extra optimizations and improve overall gas consumption for the contracts.
Note that writing to ptr instead of 0 and changing the position of the revert and return actually helps the compiler produce more optimal code :shrug:. Solidity optimizer is really a black box to me sometimes :sweat_smile:.
Additionally, marking the proxy implementation as "memory safe" has a net negative effect on the optimizer, so we intentionally don't mark it as such (even if the changes make it memory safe)
```
Gas Benchmarking [@bench]
SafeWebAuthnSignerProxy
⛽ deployment: 90100
✔ Benchmark signer deployment cost (529ms)
⛽ verification (Dummy): 12570
✔ Benchmark signer verification cost with Dummy verifier (113ms)
⛽ verification (Precompile): 13385
✔ Benchmark signer verification cost with Precompile verifier (113ms)
```
This PR is a DRAFT - as it would change the code in a meaningful way that would require us to re-audit it. If we decide that the audit competition is not enough for the SafeWebAuthnSharedSigner and we want an additional audit for that contract (likely), then we should merge this. Otherwise, the changes are not meaningful and can wait until a future version. Since we are re-auditing the SafeWebAuthnSharedSigner, we can include this small change as part of an incremental audit.
This PR marks regions of assembly that previously weren't as memory safe - this allows the IR optimizer to do a few extra optimizations and improve overall gas consumption for the contracts.
Before
After
Note that writing to
ptrinstead of0and changing the position of therevertandreturnactually helps the compiler produce more optimal code :shrug:. Solidity optimizer is really a black box to me sometimes :sweat_smile:.Additionally, marking the proxy implementation as "memory safe" has a net negative effect on the optimizer, so weintentionally don't mark it as such (even if the changes make it memory safe)
``` Gas Benchmarking [@bench] SafeWebAuthnSignerProxy ⛽ deployment: 90100 ✔ Benchmark signer deployment cost (529ms) ⛽ verification (Dummy): 12570 ✔ Benchmark signer verification cost with Dummy verifier (113ms) ⛽ verification (Precompile): 13385 ✔ Benchmark signer verification cost with Precompile verifier (113ms) ```This PR is a DRAFT - as it would change the code in a meaningful way that would require us to re-audit it. If we decide that the audit competition is not enough for theSince we are re-auditing theSafeWebAuthnSharedSignerand we want an additional audit for that contract (likely), then we should merge this. Otherwise, the changes are not meaningful and can wait until a future version.SafeWebAuthnSharedSigner, we can include this small change as part of an incremental audit.