safe-global / safe-modules

A collection of modules that can be used with the Safe contract
GNU Lesser General Public License v3.0
140 stars 73 forks source link

Use Slightly More Gas For 4337 Test #465

Closed nlordell closed 1 month ago

nlordell commented 1 month ago

Under certain conditions, an E2E test can fail because it uses slightly more gas. This PR adds a larger gas buffer to the E2E test to prevent intermittent failures.

Example failure: https://github.com/safe-global/safe-modules/actions/runs/9990468990/job/27611219692

  1) Singleton Signers [@4337]
       should deploy a new Safe with alternate signing scheme accessing associated storage:
     Error: could not coalesce error (error={ "code": -32500, "message": "verificationGas should have extra 2000 gas. has only 353" }, payload={ ... }, code=UNKNOWN_ERROR, version=6.13.1)
coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 9991309758

Details


Totals Coverage Status
Change from base Build 9990468990: 0.0%
Covered Lines: 51
Relevant Lines: 51

💛 - Coveralls