safe-global / safe-modules

A collection of modules that can be used with the Safe contract
GNU Lesser General Public License v3.0
140 stars 73 forks source link

Fix Flaky WebAuthn Shim Test #474

Closed nlordell closed 1 month ago

nlordell commented 1 month ago

Fixes #369

This PR bumps the version of @simplewebauthn/server to include a fix to which was causing flacky tests for our WebAuthn shim. It turns out that the library was not correctly dealing with leading zeros in the signature r or s values, which would cause the test to periodically fail (since the signature was random in each run - as both the private key and the challenge were randomly generated, meaning that we would occasionally have an r or s value with a leading 0 byte).

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 10058774386

Details


Totals Coverage Status
Change from base Build 10041242450: 0.0%
Covered Lines: 92
Relevant Lines: 92

💛 - Coveralls