safe-global / safe-modules

A collection of modules that can be used with the Safe contract
GNU Lesser General Public License v3.0
151 stars 74 forks source link

Fix EIP-7212 Dev Node Docker Build #484

Closed nlordell closed 3 months ago

nlordell commented 3 months ago

The docker build for the Optimism version of Geth with 7212 support was failing in CI. It turns out that this is related to a recent release of Go 1.23 which is causing Ethereum Geth and forks (such as the Optimism fork we use) to not build.

The fix it to pin to an older version of Golang (1.22 being the latest version that works). I also, in experimenting, updated the version of Optimism Geth we use to see if it would help - which it didn't, but decided to leave the change in anyhow (it is just a version bump to the source that we use to build and a small change to the patch file to account for the changed code).

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 10404096596

Details


Totals Coverage Status
Change from base Build 10402167134: 0.0%
Covered Lines: 92
Relevant Lines: 92

💛 - Coveralls