safe-global / safe-pm

Production coordination for the Safe team primarily focused on Problems that need to be solved
2 stars 5 forks source link

ERC1155 NFTs/assets are not listed in the Safe #57

Open johannesmoormann opened 2 years ago

johannesmoormann commented 2 years ago

Part 1: Define the problem

What problem are you trying to solve?

NFTs that are using the 1155 standard are not visible under Collectibles and therefore can only be interacted with on a contract level. We are currently aware of at least 4800 NFTs following this standard being stored inside Safes.

What is your hypothesis?

If we enable 1155 support for collectibles, then these users will be able to see & interact with their ERC1155 assets as they are with all other supported assets and are more likely to use the Safe as a default account for NFTs in general.

What value does this bring to our customer and/or our mission? What is the goal?

Solving this problem would be part of a minimal support strategy for NFTs, while we have not aligned on a tangible NFT strategy overall yet. Next to drastically improving the UX for the users already holding these assets with the Safe, the perception of the Safe as a viable option for safekeeping NFTs in general is increased by supporting this standard.

How do we measure it?

no. of ERC1155 NFTs stored in Safes

Links:

ERC1155 in Safes:
https://dune.xyz/queries/12772/25558

5,884 ERC-1155 Token Contracts compared to 51,968 ERC-721 Token Contracts (https://etherscan.io/tokens-nft1155 vs. https://etherscan.io/tokens-nft)

ERC1155 vs. ERC721 Dune Analysis https://dune.xyz/jaysn1ce/ERC-721-Quick-Analysis

Part 2: Shaping the problem

// Once the problem statement has passed the Great Filter, work with the team on the problem statement and elaborate on the following points to create more certainty around the problem and possible solutions. Make sure to identify dependencies and invite the necessary stakeholders early into the shaping process.

Problem Owner

@johannesmoormann

Non Goal(s)

The goal is not to provide an optimal experience for these NFTs but to allow the user basic interactions for the user with his assets.

Solution

Solution 1

Overview

Display Safe Apps inside /collectibles that are suitable for viewing and interacting with NFTs.

Existing Safe Apps that fulfill these requirements:

Zerion

plasma.finance

Add a tooltip explaining which NFTs are supported inside the web application.

Rough Scoping & Timeline

TBD with Web Team

Risk(s), Key Trade Offs & Decisions

Concept Mocks

Screenshot 2022-03-24 at 19 20 19

Rough Scoping & Timeline

Risk(s), Key Trade Offs & Decisions

Concept Mocks

Alternative solutions & ideas

Overview

Integration of ERC-1155 standard into our backend infrastructure e.g. primarily enable indexing to then be able to display them in the interface.

Open Questions

johannesmoormann commented 2 years ago

Lukas: Check out whether it is not more desirable to use other Safe apps to browse NFTs.

DmitryBespalov commented 2 years ago

If we just display ERC155 assets, would it be enough? Is sending/transfering such assets, and showing them in transaction details and transaction list also in scope?

katspaugh commented 2 years ago

Tentative design but will be updated: https://www.figma.com/file/7c0rozSCpJ2R0hKx1G7xpb/ERC1155-NFTs%2Fassets?node-id=1%3A377

katspaugh commented 2 years ago

Final design: https://www.figma.com/file/7c0rozSCpJ2R0hKx1G7xpb/ERC1155-NFTs%2Fassets?node-id=0%3A1

Screenshot 2022-05-19 at 16 06 33
vrde commented 2 years ago

:wave: my team and I manage a bunch of ERC-1155 tokens, but they don't show up in the safe. I know we can use Zerion, but would definitely prefer native support by Safe (like for ERC-721). Also AFAIK Zerion works only in mainnet, not other networks.

Why it's important for Safe UI to support the ERC-1155 standard?