search

safe-global / safe-react-apps

A repository for applications for Safe Web Interface
MIT License
97 stars 72 forks source link

Brave browser error: does not match the recipient window's origin ('null') #330

Open PaulRBerg opened 3 years ago

PaulRBerg commented 3 years ago

Description

When I load my app (the Sablier app) from localhost:3000, the app loads fine on Chrome, but it doesn't on Brave.

Environment

Steps to reproduce

  1. Open Brave
  2. Go to https://rinkeby.gnosis-safe.io on Brave
  3. Load a custom app from localhost

Expected result

The app should load like in Chrome.

Obtained result

The app doesn't load.

Screenshots

Capture d’écran 2021-07-13 à 11 02 43
PaulRBerg commented 3 years ago

After opening the issue, I realised that I can fix this by disabling the Brave shields:

Capture d’écran 2021-07-13 à 11 03 37

When I turn them off, like this:

Capture d’écran 2021-07-13 à 11 03 45

The app loads just fine. I think that we should either:

  1. Mention this in the README of the safe-apps-react-sdk.
  2. Fix this in the safe-react directly, if possible.
katspaugh commented 3 years ago

Perhaps related to gnosis/safe-react#2501.

katspaugh commented 3 years ago

Also gnosis/safe-react#1651.

JagoFigueroa commented 2 years ago

Error message does not pop up anymore but can confirm that this is still happening after the change for the third party cookies.

Screenshot 2022-02-24 at 14 13 34

Only way to see the app on brave via localhost is by disabling Trackers & ad blocking.