safe-global / safe-react-apps

A repository for applications for Safe Web Interface
MIT License
98 stars 73 forks source link

feat: add support for additional chains on ramp #786

Closed jmealy closed 7 months ago

jmealy commented 7 months ago

What it solves

Resolves #784

How this PR fixes it

How to test it

Docs: https://docs.ramp.network/assets

Screenshots

Screenshot 2024-01-19 at 14 14 26

github-actions[bot] commented 7 months ago

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

github-actions[bot] commented 7 months ago
katspaugh commented 7 months ago

@jmealy please add yourself to the CLA allowlist: https://github.com/safe-global/safe-react-apps/blob/development/.github/workflows/cla.yml#L26

katspaugh commented 7 months ago

I'm trying to test this branch on Arbitrum but it only shows me Ethereum tokens:

Screenshot 2024-01-18 at 15 45 51

@jmealy did you manage to get it to show Arbitrum tokens?

jmealy commented 7 months ago

I'm trying to test this branch on Arbitrum but it only shows me Ethereum tokens: Screenshot 2024-01-18 at 15 45 51

@jmealy did you manage to get it to show Arbitrum tokens?

I got it working now, I didn't have Arbitrum in the config.

I was using chainlist to see what Tokens to support for each chain, but it told me Arbitrum used ETH, so I only added that: https://chainlist.org/?chain=42161&search=42161

Do you want to it just have Arbitrum tokens or Etherium also?

Edit: adding both for now

katspaugh commented 7 months ago

Tested on the new chains, it now works and lists tokens on those chains correctly. ✅