search

safe-global / safe-singleton-factory

Singleton factory used by Safe related contracts
MIT License
85 stars 87 forks source link

chiado deployment failed #302

Closed radeksvarz closed 10 months ago

radeksvarz commented 10 months ago

wrt https://github.com/safe-global/safe-singleton-factory/blob/main/artifacts/10200/deployment.json

0 bytecode deployed on Chiado due to the out of gas: https://gnosis-chiado.blockscout.com/tx/0x46efdbf6252cd307cc2e2ef983b8dec3567a1a285d879ec04599d6aaa46ddfee

Is there any other safe-singleton-factory deployed on Chiado?

github-actions[bot] commented 10 months ago

⛔️ Error:
Could not fetch the chain ID from the RPC URL.
Either the RPC URL is missing, or the RPC is not responding.
Make sure your issue follows the issue template and includes the RPC URL.
:sparkles: You can edit the issue to trigger the check again. :sparkles:

mmv08 commented 10 months ago

You can use the default hardhat's factory or your own one or turn off deterministic deployment.

radeksvarz commented 10 months ago

You can use the default hardhat's factory or your own one or turn off deterministic deployment.

Sure, apologies, wrongly stated question. I was rather to ask whether Safe has any procedure in such cases like this one, so that deployments could be expected on additional address?

nlordell commented 10 months ago

I think the way that the Safe proxy factory deployment works is to not rely on Nick's method. AFAIU, we have access to the EOA that deploys the proxy factory, so we can adjust the transaction so that it doesn't revert.