search

safe-global / safe-singleton-factory

Singleton factory used by Safe related contracts
MIT License
84 stars 87 forks source link

Prefund Verification Script Overflow #586

Open nlordell opened 3 months ago

nlordell commented 3 months ago

The prefund verification script can overflow, and cause the GitHub action to not correctly mark a chain as ready to deploy (source):

Run bash ./.github/scripts/validate_new_chain_request.sh
Extracted RPC url: https://jsonrpc.euphoria.aura.network./ Trying to get the chain id...
6321 from the RPC URL is valid. Checking the chain in chainlist...
Current gas price: 0x7
Estimated deployment gas limit: 0x13f5d
Expected pre-fund: 858445
Deployer address balance: -8446744073709551616
Error: Process completed with exit code 1.
mmv08 commented 3 months ago

I guess it might be time to rewrite that to JavaScript

nlordell commented 3 months ago

I was thinking the exact same thing!

Hecate2 commented 3 months ago

Evil workaround: I sent 10^19 gwei and met overflowed minus balance -8446744073709551616 . Yet I sent another 8.5 * 10^18 gwei to let it overflow again, back to positive balancešŸ¤£