Feature: Module guard

[akshay-ap]

This PR adds support for module transactions in guards:

• Implements #335

• The new guard interface:

  interface Guard is IERC165 {
  /// @dev Checks if a transaction should be allowed.
  /// @param to The address of the recipient.
  /// @param value The value of the transaction.
  /// @param data The data of the transaction.
  /// @param operation The operation type. 0 - CALL, 1 - DELEGATECALL
  /// @param safeTxGas The gas limit for the transaction.
  /// @param baseGas The base gas limit for the transaction.
  /// @param gasPrice The gas price for the transaction.
  /// @param gasToken The token used for paying gas.
  /// @param refundReceiver The address that will receive the gas fees refund.
  /// @param signatures The signatures of the transaction.
  /// @param msgSender The sender of the message that triggered the transaction.
  function checkTransaction(
      address to,
      uint256 value,
      bytes memory data,
      Enum.Operation operation,
      uint256 safeTxGas,
      uint256 baseGas,
      uint256 gasPrice,
      address gasToken,
      address payable refundReceiver,
      bytes memory signatures,
      address msgSender
  ) external;
  
  /// @dev Checks if a module transaction should be allowed.
  /// @param to The address of the recipient.
  /// @param value The value of the transaction.
  /// @param data The data of the transaction.
  /// @param operation The operation type.
  /// @param module The module that triggered the transaction.
  function checkModuleTransaction(address to, uint256 value, bytes memory data, Enum.Operation operation, address module) external;
  
  /// @dev Checks if a transaction was successful after execution.
  /// @param txHash The hash of the transaction that was executed.
  ///        In a module transaction, hash of the transaction call data.
  /// @param success Whether or not the transaction was successful.
  function checkAfterExecution(bytes32 txHash, bool success) external;
  }

Considerations

• Incompatibility with previous guards. This should be managed through an upgrade contract, requiring either to remove a guard or provide an address for a new one which supports the new interface.
• Arguments to pass to checkAfterExecution in case of a module transaction. We don't get much data after the execution, so it was decided to keep the old method and pass the hash of the calldata

[github-actions[bot]]

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

---

I have read the CLA Document and I hereby sign the CLA

---

_{You can retrigger this bot by commenting recheck in this Pull Request}

[github-actions[bot]]

Pull Request Test Coverage Report for Build 5046998421

• 3 of 6 (50.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.5%) to 97.541%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
contracts/base/ModuleManager.sol	3	6	50.0%
<!--	Total:	3	6	50.0%	-->

Totals
Change from base Build 5024015688:	0.5%
Covered Lines:	318
Relevant Lines:	322

---

💛 - Coveralls

[akshay-ap]

Due to contract size limitation (Safe.sol and SafeL2.sol) we are not merging this feature in 1.5.0 unless another feature update reduces the size.

[akshay-ap]

recheck