safe-global / safe-smart-account

Safe allows secure management of blockchain assets.
https://safe.global
GNU Lesser General Public License v3.0
1.88k stars 927 forks source link

Remove assembly code from getChainId #586

Closed RenanSouza2 closed 1 year ago

RenanSouza2 commented 1 year ago

getChainId function can be done at solidity level

getChainId function in Safe.sol no longer needs to use assembly

Proposed solution

use block.chainId information

RenanSouza2 commented 1 year ago

Closing myself because block.chainid is only avaliable on solidity 0.8