search

safe-global / safe-smart-account

Safe allows secure management of blockchain assets.
https://safe.global
GNU Lesser General Public License v3.0
1.88k stars 927 forks source link

persistent release branches #640

Closed gosuto-inzasheru closed 1 year ago

gosuto-inzasheru commented 1 year ago

@mmv08 is it safe to assume that https://github.com/safe-global/safe-contracts/tree/release-branch/v1.4.1 will remain available longterm?

we are using safe-contracts as a submodule, so we can only pin to a branch (not to a commit or tag). so i just wanted to make sure release-branch/v1.4.1 can reliably be used for that purpose.

(i also found https://github.com/safe-global/safe-contracts/tree/release/1.4.1, which is a bit confusing, bit i see it is further behind so ignored that one for now)

mmv08 commented 1 year ago

No, you should use tags or commits. Submodules do support pinning to commits https://stackoverflow.com/questions/10914022/how-do-i-check-out-a-specific-version-of-a-submodule-using-git-submodule