safe-global / safe-smart-account

Safe allows secure management of blockchain assets.
https://safe.global
GNU Lesser General Public License v3.0
1.88k stars 927 forks source link

Formal verification: Fix unresolved setup call from the harness constructor #643

Closed mmv08 closed 1 year ago

mmv08 commented 1 year ago

While debugging our failed runs in https://github.com/safe-global/safe-contracts/pull/641, @jhoenicke pointed out in our shared Slack channel, that there was an unresolved call in the constructor method. There was a solidity compiler warning, but I previously checked this with the Certora team, and they deemed this one OK in the prover context.

This PR fixes it by munging the visibility from external to public for the setup method and also adjusting the storage location of the variables passed to the method to be callable from the constructor.

Many thanks to @jhoenicke 🙂

github-actions[bot] commented 1 year ago

Pull Request Test Coverage Report for Build 5974123615


Totals Coverage Status
Change from base Build 5892512694: 0.0%
Covered Lines: 320
Relevant Lines: 340

💛 - Coveralls