safe-global / safe-smart-account

Safe allows secure management of blockchain assets.
https://safe.global
GNU Lesser General Public License v3.0
1.88k stars 927 forks source link

Use byte instead of and in the SignatureDecoderContract #646

Closed mmv08 closed 1 year ago

mmv08 commented 1 year ago

@roleengineer suggested that we could use byte instead of and in the signature split function. After reviewing the "industry standards" contracts, that seems to be a good decision (e.g., https://github.com/OpenZeppelin/openzeppelin-contracts/blob/a5ed318634016a25be4000ee07044a31f363e60c/contracts/utils/cryptography/ECDSA.sol#L53-L70)

This PR makes the adjustment.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 6001005315


Totals Coverage Status
Change from base Build 5999462738: 0.0%
Covered Lines: 320
Relevant Lines: 340

💛 - Coveralls