Closed mmv08 closed 1 year ago
@roleengineer suggested that we could use byte instead of and in the signature split function. After reviewing the "industry standards" contracts, that seems to be a good decision (e.g., https://github.com/OpenZeppelin/openzeppelin-contracts/blob/a5ed318634016a25be4000ee07044a31f363e60c/contracts/utils/cryptography/ECDSA.sol#L53-L70)
byte
and
This PR makes the adjustment.
@roleengineer suggested that we could use
byte
instead ofand
in the signature split function. After reviewing the "industry standards" contracts, that seems to be a good decision (e.g., https://github.com/OpenZeppelin/openzeppelin-contracts/blob/a5ed318634016a25be4000ee07044a31f363e60c/contracts/utils/cryptography/ECDSA.sol#L53-L70)This PR makes the adjustment.