safe-global / safe-smart-account

Safe allows secure management of blockchain assets.
https://safe.global
GNU Lesser General Public License v3.0
1.84k stars 907 forks source link

Remove the unused bytes parameter from the checkSignatures methods #687

Closed mmv08 closed 11 months ago

mmv08 commented 11 months ago

When working on the account specifications for the Safe{Core} Protocol, one of the requirements for the signature validators was the checkSignatures(bytes32, bytes, bytes) function, where the second bytes param is unused and comes from the legacy roots in the Safe.

Nick proposed that we remove this param from the requirements to not add "Tech debt" to accounts and update the Safe implementation accordingly.

Proposed solution