safe-global / safe-smart-account

Safe allows secure management of blockchain assets.
https://safe.global
GNU Lesser General Public License v3.0
1.84k stars 907 forks source link

Explicitly Request Required PR Permission for CLA Bot #692

Closed nlordell closed 10 months ago

nlordell commented 11 months ago

Change the CLA bot to explicitly request the required permissions. This is done in accordance to the CLA bot documentation:

# explicitly configure permissions, in case your GITHUB_TOKEN workflow permissions are set to read-only in repository settings
permissions:
  actions: write
  contents: write
  pull-requests: write
  statuses: write
coveralls commented 11 months ago

Pull Request Test Coverage Report for Build 6814151879


Totals Coverage Status
Change from base Build 6720462527: 0.0%
Covered Lines: 400
Relevant Lines: 409

💛 - Coveralls
mmv08 commented 11 months ago

Does it work?

nlordell commented 11 months ago

It didn't work no, I kept the PR open as this adds the permissions that are recommended by the CLA bot documentation (see PR description), but maybe it's not needed after all.

Feel free to close if you don't think that it should be merged.