issues
search
safe-global
/
safe-smart-account
Safe allows secure management of blockchain assets.
https://safe.global
GNU Lesser General Public License v3.0
1.84k
stars
907
forks
source link
Feature: Remove unused bytes from core contract's `checkSignatures` method
#693
Closed
mmv08
closed
11 months ago
mmv08
commented
11 months ago
This PR:
Implements
https://github.com/safe-global/safe-contracts/issues/687
by removing the
bytes
parameter from the core contract's and adding the method with the old signature to the
CompatibilityFallbackHandler
Our
change
for the overloaded checkNSignatures method with the executor address came in handy when adding the backwards compatible method because we can grab the original sender's address and forward it to the method
coveralls
commented
11 months ago
Pull Request Test Coverage Report for
Build 6707500820
7
of
7
(100.0%)
changed or added relevant lines in
2
files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+
0.9%
) to
95.208%
Totals
Change from base
Build 6705456434
:
0.9%
Covered Lines:
371
Relevant Lines:
380
💛 -
Coveralls
This PR:
bytes
parameter from the core contract's and adding the method with the old signature to theCompatibilityFallbackHandler