safe-global / safe-smart-account

Safe allows secure management of blockchain assets.
https://safe.global
GNU Lesser General Public License v3.0
1.88k stars 927 forks source link

Update certora.yml to pin the cli version #697

Closed mmv08 closed 1 year ago

mmv08 commented 1 year ago

The certora-cli v5 release on 15th Nov has some breaking changes that can lead to CI runs failing. To avoid these failures, we must change run: pip install certora-cli to run: pip3 install certora-cli==4.13.1 in certora.yml under .github/workflows. This will ensure there are no failures due to the new release.

EDIT: For some reason, the coveralls action started failing with an error. Example run: https://github.com/safe-global/safe-contracts/actions/runs/6811949628/job/18526604192?pr=696

I updated our coveralls action based on an example for parallel actions at https://github.com/marketplace/actions/coveralls-github-action and https://docs.coveralls.io/parallel-builds (was linked in the failed run)

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 6814671749


Totals Coverage Status
Change from base Build 6720462527: 0.0%
Covered Lines: 400
Relevant Lines: 409

💛 - Coveralls
mmv08 commented 1 year ago

I created this PR to see if the "Waiting for status to be reported" would fix itself. It didn't, so I'm closing the PR.