Making contracts `memory-safe`

[remedcu]

This PR does the following things:

• ~Updates the solc used to 0.8.19 (Need confirmation if this should be done @nlordell / @mmv08 ) for both the project as well as FV using Certora.~
• Makes it possible to compile using 0.8.19 with viaIR and optimization enabled (To check, use .env file with solidity version and settings with the appropriate values)
• Updates assembly to be memory-safe either through tags explicitly or by using proper free memory allocation.

Closes #544

[github-actions[bot]]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[remedcu]

I have read the CLA Document and I hereby sign the CLA

[coveralls]

Pull Request Test Coverage Report for Build 7475596867

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 94.567%

---

Totals
Change from base Build 6969581763:	0.0%
Covered Lines:	397
Relevant Lines:	405

---

💛 - Coveralls

[nlordell]

No - I don’t think we want to migrate to v0.8 for the Safe contracts.

[remedcu]

I will make the necessary changes to go back to 0.7.6 👍🏾

[nlordell]

One thing that I think this PR should do, is to go over our existing "memory-safe" assembly and remove unnecessary allocations like in:

https://github.com/safe-global/safe-contracts/blob/f03dfae65fd1d085224b00a10755c509a4eaacfe/contracts/base/FallbackManager.sol#L72-L75

For reference and some more context: https://github.com/safe-global/safe-core-protocol-specs/pull/67

[mmv08]

Do you have an idea why this job failed? Also, it's interesting that it exited with 0 code.

https://github.com/safe-global/safe-contracts/actions/runs/7300399750/job/19894950822?pr=711

[remedcu]

Nice catch! Could be because of this: https://github.com/safe-global/safe-contracts/blob/optimizer-enabled/.github/workflows/ci.yml#L74

If you turn viaIR: false, it should work.

An issue was created for this in the backlog: https://github.com/orgs/safe-global/projects/14/views/10?sliceBy%5Bvalue%5D=Protocol&pane=issue&itemId=48283099

P.S. This benchmark has been failing for quite some time now that I checked. The last history I could find in the main was this one: https://github.com/safe-global/safe-contracts/actions/runs/6456132696/job/17524992449 (which is a 4-month-old merge to main branch)

[remedcu]

Do you have an idea why this job failed?

It is passing now @mmv08 https://github.com/safe-global/safe-contracts/actions/runs/7422997985/job/20199462482?pr=711

[remedcu]

Will make a new issue & PR once this is merged for the returndatasize. Will merge this one, once all the checks pass.

Thank you all for reviewing this PR!