safe-global / safe-smart-account

Safe allows secure management of blockchain assets.
https://safe.global
GNU Lesser General Public License v3.0
1.84k stars 907 forks source link

Correctly returning data from tx execution through module #728

Closed remedcu closed 8 months ago

remedcu commented 8 months ago

The execTransactionFromModuleReturnData(...) returned data from guard execution, if a guard was enabled. It was rectified by assigning the returnData to the return value from the execute(...) and then running the post-tx checks in the guard. As these pre and post-checks through guards were shared between all execTransactionFromModule*(...), internal functions were written for the same.

Closes #708

coveralls commented 8 months ago

Pull Request Test Coverage Report for Build 7503212266


Totals Coverage Status
Change from base Build 7476408467: 0.04%
Covered Lines: 400
Relevant Lines: 408

💛 - Coveralls