Remove OR operator from the benchmark job

safe-global / safe-smart-account

Safe allows secure management of blockchain assets.

https://safe.global

GNU Lesser General Public License v3.0

1.84k stars 907 forks source link

Remove OR operator from the benchmark job #736

Closed mmv08 closed 7 months ago

mmv08 commented 7 months ago

This PR:

Fix the benchmark CI job to prebent regressions like https://github.com/safe-global/safe-smart-account/issues/735. It is fixed by removing the OR operator because if a benchmark failed, it only outputted a message but didn't return a non-zero exit code.
Also bumps the 0.8.x compiler version to the latest one (0.8.24)

coveralls commented 7 months ago

Pull Request Test Coverage Report for Build 7783407281

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall first build on bug/benchmark-ci-silent-fail at 94.397%

Totals
Change from base Build 7609222733:	94.4%
Covered Lines:	396
Relevant Lines:	404

💛 - Coveralls

mmv08 commented 7 months ago

We had a discussion in Slack and decided to merge this to keep this as a heads-up. This failing job should not block PRs from merging (currently, only tests jobs are required to pass)