safe-global / safe-smart-account

Safe allows secure management of blockchain assets.
https://safe.global
GNU Lesser General Public License v3.0
1.84k stars 907 forks source link

zksync branch doesn't seem to contain correct zksync deployment scripts #749

Closed novaknole closed 5 months ago

novaknole commented 5 months ago

Description

I was looking into how safe wrote a script for deploying the contracts on zksync. This repository has a zksync branch which seems to have zksync deployment integrated. The problem I see is you use zksync-deploy package to start running the scripts, but deploy scripts in deploy folder still uses hardhat-deploy package.

What's strange to me is how this works. hardhat-deploy version that is used is 0.9.2 on which there's no zksync support at all. So how did you deploy to zksync with this script that lives on zksync branch ?