safe-global / safe-smart-account

Safe allows secure management of blockchain assets.
https://safe.global
GNU Lesser General Public License v3.0
1.84k stars 907 forks source link

Update Compatibility Signature Verification Functions #750

Closed nlordell closed 5 months ago

nlordell commented 5 months ago

I was trying to move the signature verification logic to use calldata instead of memory for the signature bytes and decided to make some small changes to the documentation around the legacy checkSignatures functions.

Additionally, since we have additional code size, we were able to move the legacy checkSignatures back into the Safe contract so continued compatibility with existing Safes does not require specific fallback handlers.

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 8736116277

Details


Totals Coverage Status
Change from base Build 8617384014: 0.02%
Covered Lines: 398
Relevant Lines: 406

💛 - Coveralls