Closed akshay-ap closed 4 months ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
contracts/base/GuardManager.sol | 1 | 2 | 50.0% | ||
contracts/examples/guards/DebugTransactionGuard.sol | 0 | 1 | 0.0% | ||
contracts/examples/guards/ReentrancyTransactionGuard.sol | 0 | 1 | 0.0% | ||
contracts/base/ModuleManager.sol | 9 | 11 | 81.82% | ||
<!-- | Total: | 13 | 18 | 72.22% | --> |
Totals | |
---|---|
Change from base Build 8900628538: | -1.5% |
Covered Lines: | 388 |
Relevant Lines: | 400 |
Thanks for approval! I will merge it this week after a final self-review as this is an important change in the account contract.
Fixes #755
Summary of changes:
The PR creates a separate interface for Module guards instead of having a single
Guard
interface for both module transactions and Safe transactions.The new Module guard interface i.e, IModuleGuard has two functions:
checkModuleTransaction
checkAfterExecution
The updated addresses in migration contracts are taken from logs from the tests.
Rename interface
Guard
toITransactionGuard
.Fix typo: Rename
ModuleTransasctionDetails
toModuleTransactionDetails
Codesize: Main branch:
This PR (+571 bytes):
Changes in PR:
Open for discussion:
Guard
toITransactionGuard
? -> YessetGuard
function tosetTransactionGuard
? : Impacts Safe interfaceChangedGuard
event toChangedTransactionGuard
? Impacts services monitoring this event