Add zkSync Support To Repository - Githubissues

safe-global / safe-smart-account

Safe allows secure management of blockchain assets.

https://safe.global

GNU Lesser General Public License v3.0

1.79k stars 875 forks source link

Add zkSync Support To Repository #766

Open nlordell opened 1 week ago

nlordell commented 1 week ago

Context / issue

Currently, the Safe contracts package does not have good support for zkSync. Specifically, the test suite cannot run against a zkSync network.

Proposed solution

Add zkSync support to the package so that the Safe contract test suite can run on a zkSync devnet.

Currently, the proposal would be to use the existing zkSync - Hardhat integration with the in-memory node.

The expected outcome is to add to the v1.4.1 branch:

[ ] Deployment scripts added to package.json that work on zkSync networks
[ ] Instructions on how to deploy to zkSync networks
[ ] Test suite passes on zkSync developer network

Additional context

Existing attempts at adding support have been included in:

625
742

mmv08 commented 1 week ago

So there seems to be a bug in the in-memory node and zksync is rejecting to accept this as a bug: https://github.com/zkSync-Community-Hub/zksync-developers/discussions/482