Audit Changes for `v1.4.1-2` cherry picked from `release/v1.4.1-2`

safe-global / safe-smart-account

Safe allows secure management of blockchain assets.

https://safe.global

GNU Lesser General Public License v3.0

1.88k stars 927 forks source link

Audit Changes for `v1.4.1-2` cherry picked from `release/v1.4.1-2` #815

Closed remedcu closed 2 months ago

remedcu commented 2 months ago

This PR makes the changes based on Certora's audit report from the branch release/v1.4.1-2 to main.

In the release branch, we used the ISafe contract written inside the respective library files, but with main, we use the ISafe standard interface in the interfaces folder. Similarly, Enum was moved from common to libraries, and thus that is used for the same in the migration contracts.

Note: A fmt change was made to DebugTransactionGuard.sol.

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 10597342302

Details

18 of 18 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.09%) to 93.571%

Totals
Change from base Build 10451906756:	0.09%
Covered Lines:	396
Relevant Lines:	408

💛 - Coveralls

remedcu commented 2 months ago

(make sure to not squash the commit, because it'll create a new one)

The commit SHA is already different because of the changes mentioned in the description.

Original Commit SHA: 75018fbd89a53b04836dde9ee51076161a64f48c

nlordell commented 2 months ago

(make sure to not squash the commit, because it'll create a new one)

I think its fine to squash commit. We have to re-audit for 1.5.0 anyway.