Update CHANGELOG.md - Githubissues

safe-global / safe-smart-account

Safe allows secure management of blockchain assets.

https://safe.global

GNU Lesser General Public License v3.0

1.88k stars 927 forks source link

Update CHANGELOG.md #816

Closed akshay-ap closed 2 months ago

akshay-ap commented 2 months ago

Fixes #790

Changes in PR:

Mention new added contracts: SafeMigration and SafeToL2Setup
Mention new module guard interface IModuleGuard
Update expected contract addresse

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 10630626622

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 93.478%

Totals
Change from base Build 10613396108:	0.0%
Covered Lines:	386
Relevant Lines:	398

💛 - Coveralls

mmv08 commented 2 months ago

In my understanding, the new migration contracts will be released as an incremental release of 1.4.1 (1.4.1-3 or something similar) and not as part of 1.5.0.

If we decide to release it as part of 1.5.0, that means we released a version without providing an upgrade mechanism, so I believe the migration contract should be part of the 1.4.1 changelog. I'm not sure about the SafeToL2Setup, but I think it's alright if we do it in 1.4.1 as well.

akshay-ap commented 2 months ago

In my understanding, the new migration contracts will be released as an incremental release of 1.4.1 (1.4.1-3 or something similar) and not as part of 1.5.0.

If we decide to release it as part of 1.5.0, that means we released a version without providing an upgrade mechanism, so I believe the migration contract should be part of the 1.4.1 changelog. I'm not sure about the SafeToL2Setup, but I think it's alright if we do it in 1.4.1 as well.

Fine with moving to 1.4.1. cc @nlordell