Optimize load of addresses in indexer

safe-global / safe-transaction-service

Keeps track of transactions sent via Safe contacts and confirmed transactions. It also keeps track of Ether and ERC20 token transfers to Safe contracts.

MIT License

182 stars 246 forks source link

Optimize load of addresses in indexer #2079

Closed Uxio0 closed 3 weeks ago

Uxio0 commented 3 weeks ago

Make indexers use sets instead of db instances

Previously, MonitoredAddress instances were used.
Currently, only address is retrieved from database, and transformed into a set
This approach is:
- More optimal both on CPU/RAM, as it does not have to use a list and then convert to a set
- Easier to cache (in a following PR)
- Easiert to extend and implement new indexers
Tests and indexers were refactored
Typing was checked and fixed

Uxio0 commented 3 weeks ago

@moisses89 I applied the changes suggested, this is ready for review again

JagoFigueroa commented 3 weeks ago

Hola! I have been transacting in Sepolia (L1) and Polygon (L2) and no issues so far. Will keep an eye but looking good to me 😄